Tests passing on 8.3 and 8.4#41
Closed
rossaddison wants to merge 82 commits intoyiisoft:masterfrom
Closed
Conversation
Contributor
rossaddison
commented
Sep 3, 2025
| Q | A |
|---|---|
| Is bugfix? | ✔️/❌ |
| New feature? | ✔️/❌ |
| Breaks BC? | ✔️/❌ |
There should be 14 tests ... as in yiisoft data. Testing with test folder's .env file adjusted for mysql
All tests are linked to yiisoft/data test material.
The two escaped mutants are:
1) C:\wamp64\www\data-cycle\src\Reader\EntityReader.php:189 [M] IncrementInteger
@@ @@
public function readOne(): null|array|object
{
if (!$this->oneItemCache->isCollected()) {
- $item = $this->itemsCache->isCollected() ? $this->itemsCache->getGenerator()->current() : $this->withLimit(1)->getIterator()->current();
+ $item = $this->itemsCache->isCollected() ? $this->itemsCache->getGenerator()->current() : $this->withLimit(2)->getIterator()->current();
$this->oneItemCache->setCollection($item === null ? [] : [$item]);
}
/**
Applied yiisoft/data/pull/234 Moved tests folder into psalm.xml - Level 1 tested EntityReader's readOne function's limit(1) has been removed to get the msi to 100. A suitable test needs to be developed to check for the IncrementInteger mutant on the readOne function with the mutant that changes limit(1) to limit(2) still causing a failure with current tests not picking it up mainly due to the \Generator->current returning mixed type where null, array, and object have to be checked in readOne with false also being returned.
Allow the connection to be created even if the password is empty which matches the CI config.
Convert empty string to null
samdark
requested changes
Sep 7, 2025
No js dependencies required
samdark
requested changes
Sep 9, 2025
samdark
requested changes
Sep 10, 2025
Member
|
@rossaddison was it created with the help of LLMs? If so, please at least read it manually. There are tons of obvious weird places to fix. LLM doesn't seem to be able to handle it properly. |
Contributor
Author
Please elaborate |
Member
|
I mean, it feels generated and seems to need either many iterations or manual checking-fixing to be of acceptable quality. |
samdark
requested changes
Sep 10, 2025
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
samdark
requested changes
Sep 11, 2025
| ]); | ||
|
|
||
| return (new Config()) | ||
| ->setCacheFile(__DIR__ . '/runtime/cache/.php-cs-fixer.cache') |
Member
|
@rossaddison check the diff. There are many comments from previous reviews that were not addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.