Skip to content

Tests passing on 8.3 and 8.4#41

Closed
rossaddison wants to merge 82 commits intoyiisoft:masterfrom
rossaddison:master
Closed

Tests passing on 8.3 and 8.4#41
rossaddison wants to merge 82 commits intoyiisoft:masterfrom
rossaddison:master

Conversation

@rossaddison
Copy link
Copy Markdown
Contributor

Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌

There should be 14 tests ... as in yiisoft data.
Testing with test folder's .env file adjusted for mysql
All tests are linked to yiisoft/data test material.
The two escaped mutants are:

1) C:\wamp64\www\data-cycle\src\Reader\EntityReader.php:189    [M] IncrementInteger

@@ @@
     public function readOne(): null|array|object
     {
         if (!$this->oneItemCache->isCollected()) {
-            $item = $this->itemsCache->isCollected() ? $this->itemsCache->getGenerator()->current() : $this->withLimit(1)->getIterator()->current();
+            $item = $this->itemsCache->isCollected() ? $this->itemsCache->getGenerator()->current() : $this->withLimit(2)->getIterator()->current();
             $this->oneItemCache->setCollection($item === null ? [] : [$item]);
         }
         /**
Applied  yiisoft/data/pull/234
Moved tests folder into psalm.xml - Level 1 tested
EntityReader's readOne function's limit(1) has been removed to get the msi to 100.

A suitable test needs to be developed to check for the IncrementInteger mutant on the readOne function with the mutant that changes limit(1) to limit(2) still causing a failure with current tests not picking it up mainly due to the \Generator->current returning mixed type where null, array, and object have to be checked in readOne with false also being returned.
 Allow the connection to be created even if the password is empty which matches the CI config.
Comment thread composer.json Outdated
Comment thread package.json Outdated
@rossaddison rossaddison requested a review from samdark September 8, 2025 16:27
Comment thread runtime/cache/.php-cs-fixer.cache Outdated
Comment thread src/Reader/EntityReader.php Outdated
Comment thread src/Reader/EntityReader.php Outdated
Comment thread src/Reader/EntityReader.php Outdated
@rossaddison rossaddison requested a review from samdark September 10, 2025 20:04
Comment thread .github/workflows/composer-require-checker.yml Outdated
Comment thread .github/workflows/mssql.yml Outdated
@samdark
Copy link
Copy Markdown
Member

samdark commented Sep 10, 2025

@rossaddison was it created with the help of LLMs? If so, please at least read it manually. There are tons of obvious weird places to fix. LLM doesn't seem to be able to handle it properly.

@rossaddison
Copy link
Copy Markdown
Contributor Author

@rossaddison was it created with the help of LLMs? If so, please at least read it manually. There are tons of obvious weird places to fix. LLM doesn't seem to be able to handle it properly.

Please elaborate

@rossaddison rossaddison requested a review from samdark September 10, 2025 21:30
@samdark
Copy link
Copy Markdown
Member

samdark commented Sep 10, 2025

I mean, it feels generated and seems to need either many iterations or manual checking-fixing to be of acceptable quality.

Comment thread .github/workflows/mutation.yml Outdated
Comment thread .github/workflows/pgsql.yml Outdated
Comment thread .github/workflows/sqlite.yml Outdated
Comment thread .github/workflows/static.yml Outdated
Comment thread .php-cs-fixer.php Outdated
Comment thread src/Reader/FilterHandler/LikeHandler/SqliteLikeHandler.php Outdated
Comment thread src/Reader/FilterHandler/LikeHandler/SqliteLikeHandler.php Outdated
Comment thread src/Reader/FilterHandler/NotHandler.php Outdated
Comment thread tests/Feature/Base/Writer/BaseEntityWriterTestCase.php Outdated
Comment thread tests/Feature/Mysql/Reader/ReaderWithFilter/ReaderWithLikeTest.php
@rossaddison rossaddison requested a review from samdark September 11, 2025 12:41
Comment thread .php-cs-fixer.php
]);

return (new Config())
->setCacheFile(__DIR__ . '/runtime/cache/.php-cs-fixer.cache')
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still relevant.

@samdark
Copy link
Copy Markdown
Member

samdark commented Sep 11, 2025

@rossaddison check the diff. There are many comments from previous reviews that were not addressed.

@samdark samdark closed this Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants